Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 040587af authored by Simon Horman's avatar Simon Horman Committed by David S. Miller
Browse files

net/sched: cls_flower: Correct matching on ICMPv6 code 



When matching on the ICMPv6 code ICMPV6_CODE rather than
ICMPV4_CODE attributes should be used.

This corrects what appears to be a typo.

Sample usage:

tc qdisc add dev eth0 ingress
tc filter add dev eth0 protocol ipv6 parent ffff: flower \
	indev eth0 ip_proto icmpv6 type 128 code 0 action drop

Without this change the code parameter above is effectively ignored.

Fixes: 7b684884 ("net/sched: cls_flower: Support matching on ICMP type and code")
Signed-off-by: default avatarSimon Horman <simon.horman@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0d29ed28

net/sched/cls_flower.c

+2 −2
Original line number Diff line number Diff line
@@ -568,9 +568,9 @@ static int fl_set_key(struct net *net, struct nlattr **tb, 
			       &mask->icmp.type,

			       TCA_FLOWER_KEY_ICMPV6_TYPE_MASK,

			       sizeof(key->icmp.type));

		fl_set_key_val(tb, &key->icmp.code, TCA_FLOWER_KEY_ICMPV4_CODE,

		fl_set_key_val(tb, &key->icmp.code, TCA_FLOWER_KEY_ICMPV6_CODE,

			       &mask->icmp.code,

			       TCA_FLOWER_KEY_ICMPV4_CODE_MASK,

			       TCA_FLOWER_KEY_ICMPV6_CODE_MASK,

			       sizeof(key->icmp.code));

	}