Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 039b1d5e authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller
Browse files

net: cisco: enic: Replace GFP_ATOMIC with GFP_KERNEL 



vnic_dev_register(), vnic_rq_alloc_bufs() and vnic_wq_alloc_bufs()
are never called in atomic context.
They call kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: default avatarGovindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 07d53ae4

drivers/net/ethernet/cisco/enic/vnic_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -1071,7 +1071,7 @@ struct vnic_dev *vnic_dev_register(struct vnic_dev *vdev, 
	unsigned int num_bars)

{

	if (!vdev) {

		vdev = kzalloc(sizeof(struct vnic_dev), GFP_ATOMIC);

		vdev = kzalloc(sizeof(struct vnic_dev), GFP_KERNEL);

		if (!vdev)

			return NULL;

	}

drivers/net/ethernet/cisco/enic/vnic_rq.c

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ static int vnic_rq_alloc_bufs(struct vnic_rq *rq) 
	unsigned int blks = VNIC_RQ_BUF_BLKS_NEEDED(count);



	for (i = 0; i < blks; i++) {

		rq->bufs[i] = kzalloc(VNIC_RQ_BUF_BLK_SZ(count), GFP_ATOMIC);

		rq->bufs[i] = kzalloc(VNIC_RQ_BUF_BLK_SZ(count), GFP_KERNEL);

		if (!rq->bufs[i])

			return -ENOMEM;

	}

drivers/net/ethernet/cisco/enic/vnic_wq.c

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ static int vnic_wq_alloc_bufs(struct vnic_wq *wq) 
	unsigned int blks = VNIC_WQ_BUF_BLKS_NEEDED(count);



	for (i = 0; i < blks; i++) {

		wq->bufs[i] = kzalloc(VNIC_WQ_BUF_BLK_SZ(count), GFP_ATOMIC);

		wq->bufs[i] = kzalloc(VNIC_WQ_BUF_BLK_SZ(count), GFP_KERNEL);

		if (!wq->bufs[i])

			return -ENOMEM;

	}