Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 03679a14 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: dsa: bcm_sf2: Fix 64-bits register writes 



The macro to write 64-bits quantities to the 32-bits register swapped
the value and offsets arguments, we want to preserve the ordering of the
arguments with respect to how writel() is implemented for instance:
value first, offset/base second.

Fixes: 246d7f77 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 687f0715

drivers/net/dsa/bcm_sf2.h

+2 −2
Original line number Diff line number Diff line
@@ -112,8 +112,8 @@ static inline u64 name##_readq(struct bcm_sf2_priv *priv, u32 off) \ 
	spin_unlock(&priv->indir_lock);					\

	return (u64)indir << 32 | dir;					\

}									\

static inline void name##_writeq(struct bcm_sf2_priv *priv, u32 off,	\

							u64 val)	\

static inline void name##_writeq(struct bcm_sf2_priv *priv, u64 val,	\

							u32 off)	\

{									\

	spin_lock(&priv->indir_lock);					\

	reg_writel(priv, upper_32_bits(val), REG_DIR_DATA_WRITE);	\