Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0283fbb1 authored by Jayamohan Kallickal's avatar Jayamohan Kallickal Committed by James Bottomley
Browse files

[SCSI] be2iscsi: Fix lack of uninitialize pattern to FW 



This patch sends uninitialize pattern to FW during driver unload
which is expected by FW for cleanup

Signed-off-by: default avatarJohn Soni Jose <sony.john-n@emulex.com>
Signed-off-by: default avatarJayamohan Kallickal <jayamohan.kallickal@emulex.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 4f8d1bd2

drivers/scsi/be2iscsi/be_cmds.c

+51 −0
Original line number Diff line number Diff line
@@ -732,6 +732,16 @@ int beiscsi_cmd_eq_create(struct be_ctrl_info *ctrl, 
	return status;

}



/**

 * be_cmd_fw_initialize()- Initialize FW

 * @ctrl: Pointer to function control structure

 *

 * Send FW initialize pattern for the function.

 *

 * return

 * Success: 0

 * Failure: Non-Zero value

 **/

int be_cmd_fw_initialize(struct be_ctrl_info *ctrl)

{

	struct be_mcc_wrb *wrb = wrb_from_mbox(&ctrl->mbox_mem);
@@ -762,6 +772,47 @@ int be_cmd_fw_initialize(struct be_ctrl_info *ctrl) 
	return status;

}



/**

 * be_cmd_fw_uninit()- Uinitialize FW

 * @ctrl: Pointer to function control structure

 *

 * Send FW uninitialize pattern for the function

 *

 * return

 * Success: 0

 * Failure: Non-Zero value

 **/

int be_cmd_fw_uninit(struct be_ctrl_info *ctrl)

{

	struct be_mcc_wrb *wrb = wrb_from_mbox(&ctrl->mbox_mem);

	struct beiscsi_hba *phba = pci_get_drvdata(ctrl->pdev);

	int status;

	u8 *endian_check;



	spin_lock(&ctrl->mbox_lock);

	memset(wrb, 0, sizeof(*wrb));



	endian_check = (u8 *) wrb;

	*endian_check++ = 0xFF;

	*endian_check++ = 0xAA;

	*endian_check++ = 0xBB;

	*endian_check++ = 0xFF;

	*endian_check++ = 0xFF;

	*endian_check++ = 0xCC;

	*endian_check++ = 0xDD;

	*endian_check = 0xFF;



	be_dws_cpu_to_le(wrb, sizeof(*wrb));



	status = be_mbox_notify(ctrl);

	if (status)

		beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_INIT,

			    "BC_%d : be_cmd_fw_uninit Failed\n");



	spin_unlock(&ctrl->mbox_lock);

	return status;

}



int beiscsi_cmd_cq_create(struct be_ctrl_info *ctrl,

			  struct be_queue_info *cq, struct be_queue_info *eq,

			  bool sol_evts, bool no_delay, int coalesce_wm)

drivers/scsi/be2iscsi/be_cmds.h

+1 −0
Original line number Diff line number Diff line
@@ -697,6 +697,7 @@ int beiscsi_mccq_compl(struct beiscsi_hba *phba, 
			uint32_t tag, struct be_mcc_wrb **wrb, void *cmd_va);

/*ISCSI Functuions */

int be_cmd_fw_initialize(struct be_ctrl_info *ctrl);

int be_cmd_fw_uninit(struct be_ctrl_info *ctrl);



struct be_mcc_wrb *wrb_from_mbox(struct be_dma_mem *mbox_mem);

struct be_mcc_wrb *wrb_from_mccq(struct beiscsi_hba *phba);

drivers/scsi/be2iscsi/be_main.c

+1 −0
Original line number Diff line number Diff line
@@ -3430,6 +3430,7 @@ static void hwi_cleanup(struct beiscsi_hba *phba) 
			beiscsi_cmd_q_destroy(ctrl, q, QTYPE_EQ);

	}

	be_mcc_queues_destroy(phba);

	be_cmd_fw_uninit(ctrl);

}



static int be_mcc_queues_create(struct beiscsi_hba *phba,