Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 025d0dfc authored by Andy Shevchenko's avatar Andy Shevchenko Committed by David S. Miller
Browse files

s390/qeth: use kstrtobool() in qeth_bridgeport_hostnotification_store() 



The sysfs enabled value is a boolean, so kstrtobool() is a better fit
for parsing the input string since it does the range checking for us.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarJulian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ed2e93ef

drivers/s390/net/qeth_l2_sys.c

+5 −8
Original line number Diff line number Diff line
@@ -146,18 +146,15 @@ static ssize_t qeth_bridgeport_hostnotification_store(struct device *dev, 
		struct device_attribute *attr, const char *buf, size_t count)

{

	struct qeth_card *card = dev_get_drvdata(dev);

	int rc = 0;

	int enable;

	bool enable;

	int rc;



	if (!card)

		return -EINVAL;



	if (sysfs_streq(buf, "0"))

		enable = 0;

	else if (sysfs_streq(buf, "1"))

		enable = 1;

	else

		return -EINVAL;

	rc = kstrtobool(buf, &enable);

	if (rc)

		return rc;



	mutex_lock(&card->conf_mutex);