Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01affb00 authored by Brad Love's avatar Brad Love Committed by Mauro Carvalho Chehab
Browse files

media: em28xx: Fix DualHD broken second tuner 



The use of a hard coded i2c address breaks the creation of the
second tuner in DualHD 01595 models. The issue is compounded
by lack of any error message stating that a driver failed
initialization. Use addr, which contains the correct address
for each tuner.

Fixes: ad32495b ("media: em28xx-dvb: simplify DVB module probing logic")

Signed-off-by: default avatarBrad Love <brad@nextdimension.cc>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 4573027b

drivers/media/usb/em28xx/em28xx-dvb.c

+1 −1
Original line number Diff line number Diff line
@@ -1393,7 +1393,7 @@ static int em28174_dvb_init_hauppauge_wintv_dualhd_01595(struct em28xx *dev) 


	dvb->i2c_client_tuner = dvb_module_probe("si2157", NULL,

						 adapter,

						 0x60, &si2157_config);

						 addr, &si2157_config);

	if (!dvb->i2c_client_tuner) {

		dvb_module_release(dvb->i2c_client_demod);

		return -ENODEV;