Commit 01a44055 authored Oct 15, 2019 by Faiz Abbas Committed by Greg Kroah-Hartman Oct 29, 2019

mmc: cqhci: Commit descriptors before setting the doorbell



commit c07d0073b9ec80a139d07ebf78e9c30d2a28279e upstream.

Add a write memory barrier to make sure that descriptors are actually
written to memory, before ringing the doorbell.

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6ea856ef

drivers/mmc/host/cqhci.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -617,7 +617,8 @@ static int cqhci_request(struct mmc_host mmc, struct mmc_request mrq)
		cq_host->slot[tag].flags = 0;

		cq_host->qcnt += 1;

		/* Make sure descriptors are ready before ringing the doorbell */
		wmb();
		cqhci_writel(cq_host, 1 << tag, CQHCI_TDBR);
		if (!(cqhci_readl(cq_host, CQHCI_TDBR) & (1 << tag)))
		pr_debug("%s: cqhci: doorbell not set for tag %d\n",