Commit 019b13ae authored Jun 27, 2017 by Matthias Schiffer Committed by David S. Miller Jun 27, 2017

vxlan: fix incorrect nlattr access in MTU check



The access to the wrong variable could lead to a NULL dereference and
possibly other invalid memory reads in vxlan newlink/changelink requests
with a IFLA_MTU attribute.

Fixes: a985343b "vxlan: refactor verification and application of configuration"
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c017ce0a

drivers/net/vxlan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2727,7 +2727,7 @@ static int vxlan_validate(struct nlattr tb[], struct nlattr data[],
		}

		if (tb[IFLA_MTU]) {
		u32 mtu = nla_get_u32(data[IFLA_MTU]);
		u32 mtu = nla_get_u32(tb[IFLA_MTU]);

		if (mtu < ETH_MIN_MTU \|\| mtu > ETH_MAX_MTU)
		return -EINVAL;