Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01817d19 authored by Julia Lawall's avatar Julia Lawall Committed by Florian Tobias Schandinat
Browse files

drivers/video/auo_k190x.c: drop kfree of devm_kzalloc's data 

Using kfree to free data allocated with devm_kzalloc causes double frees.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x;
@@

x = devm_kzalloc(...)
...
?-kfree(x);
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent 72caa5fb

drivers/video/auo_k190x.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -987,7 +987,6 @@ int __devinit auok190x_common_probe(struct platform_device *pdev, 
	fb_dealloc_cmap(&info->cmap);

	fb_dealloc_cmap(&info->cmap);

err_cmap:

err_cmap:

	fb_deferred_io_cleanup(info);

	fb_deferred_io_cleanup(info);

	kfree(info->fbdefio);

err_defio:

err_defio:

	vfree((void *)info->screen_base);

	vfree((void *)info->screen_base);

err_irq:

err_irq:
@@ -1022,7 +1021,6 @@ int __devexit auok190x_common_remove(struct platform_device *pdev) 
	fb_dealloc_cmap(&info->cmap);

	fb_dealloc_cmap(&info->cmap);





	fb_deferred_io_cleanup(info);

	fb_deferred_io_cleanup(info);

	kfree(info->fbdefio);





	vfree((void *)info->screen_base);

	vfree((void *)info->screen_base);