Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 017b9b35 authored by Markus Elfring's avatar Markus Elfring Committed by Mark Brown
Browse files

ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() 



Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent cce7c0ac

sound/soc/codecs/wm8903.c

+3 −5
Original line number Diff line number Diff line
@@ -1995,8 +1995,7 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, 
	unsigned int val, irq_pol;

	int ret, i;



	wm8903 = devm_kzalloc(&i2c->dev,  sizeof(struct wm8903_priv),

			      GFP_KERNEL);

	wm8903 = devm_kzalloc(&i2c->dev, sizeof(*wm8903), GFP_KERNEL);

	if (wm8903 == NULL)

		return -ENOMEM;
@@ -2017,8 +2016,7 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, 
	if (pdata) {

		wm8903->pdata = pdata;

	} else {

		wm8903->pdata = devm_kzalloc(&i2c->dev,

					sizeof(struct wm8903_platform_data),

		wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(*wm8903->pdata),

					     GFP_KERNEL);

		if (!wm8903->pdata)

			return -ENOMEM;