Commit 015a9e66 authored Sep 08, 2017 by Linus Torvalds

RDMA/netlink: clean up message validity array initializer



The fix in the parent made me look at that function, and react to how
illogical and illegible the array initializer was.

Use named array indexes to make it clearer what is going on, and make
the initializer not depend silently on the exact index numbers.

[ The initializer now also shows an odd inconsistency in the naming:
  note the IWCM vs IWPM..   - Linus ]

Cc: Leon Romanovsky <leonro@mellanox.com>
Cc: Doug Ledford <dledford@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8b2c7e7a

drivers/infiniband/core/netlink.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -58,12 +58,11 @@ EXPORT_SYMBOL(rdma_nl_chk_listeners);
		static bool is_nl_msg_valid(unsigned int type, unsigned int op)
		{
		static const unsigned int max_num_ops[RDMA_NL_NUM_CLIENTS] = {
		0,
		RDMA_NL_RDMA_CM_NUM_OPS,
		RDMA_NL_IWPM_NUM_OPS,
		0,
		RDMA_NL_LS_NUM_OPS,
		RDMA_NLDEV_NUM_OPS };
		[RDMA_NL_RDMA_CM] = RDMA_NL_RDMA_CM_NUM_OPS,
		[RDMA_NL_IWCM] = RDMA_NL_IWPM_NUM_OPS,
		[RDMA_NL_LS] = RDMA_NL_LS_NUM_OPS,
		[RDMA_NL_NLDEV] = RDMA_NLDEV_NUM_OPS,
		};

		/*
		* This BUILD_BUG_ON is intended to catch addition of new