Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 014bcd28 authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

hwmon: (w83795) Silent false warning from gcc 



The code triggers a false warning with older versions of gcc:
w83795.c: In function 'w83795_update_device':
w83795.c:475: warning: 'lsb' may be used uninitialized in this function

I admit that the code is a little tricky, but I see no way to write it
differently without hurting performance. So let's just silent the
warning with a needless initialization.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent 5d84291d

drivers/hwmon/w83795.c

+2 −2
Original line number Diff line number Diff line
@@ -458,6 +458,7 @@ static void w83795_update_limits(struct i2c_client *client) 
{

	struct w83795_data *data = i2c_get_clientdata(client);

	int i, limit;

	u8 lsb;



	/* Read the voltage limits */

	for (i = 0; i < ARRAY_SIZE(data->in); i++) {
@@ -479,9 +480,8 @@ static void w83795_update_limits(struct i2c_client *client) 
	}



	/* Read the fan limits */

	lsb = 0; /* Silent false gcc warning */

	for (i = 0; i < ARRAY_SIZE(data->fan); i++) {

		u8 lsb;



		/* Each register contains LSB for 2 fans, but we want to

		 * read it only once to save time */

		if ((i & 1) == 0 && (data->has_fan & (3 << i)))