Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01386957 authored by Felix Fietkau's avatar Felix Fietkau Committed by Greg Kroah-Hartman
Browse files

net: bridge: fix multicast-to-unicast with fraglist GSO 



[ Upstream commit 59c878cbcdd80ed39315573b3511d0acfd3501b5 ]

Calling skb_copy on a SKB_GSO_FRAGLIST skb is not valid, since it returns
an invalid linearized skb. This code only needs to change the ethernet
header, so pskb_copy is the right function to call here.

Fixes: 6db6f0ea ("bridge: multicast to unicast")
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
Acked-by: default avatarPaolo Abeni <pabeni@redhat.com>
Acked-by: default avatarNikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0c27eb63

net/bridge/br_forward.c

+1 −1
Original line number Diff line number Diff line
@@ -259,7 +259,7 @@ static void maybe_deliver_addr(struct net_bridge_port *p, struct sk_buff *skb, 
	if (skb->dev == p->dev && ether_addr_equal(src, addr))

		return;



	skb = skb_copy(skb, GFP_ATOMIC);

	skb = pskb_copy(skb, GFP_ATOMIC);

	if (!skb) {

		DEV_STATS_INC(dev, tx_dropped);

		return;