Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 011b2a36 authored by Ben Dooks's avatar Ben Dooks Committed by Thomas Gleixner
Browse files

[MTD] Fixup probing logic for single 16bit devices 



The change to the generic probe to look for the
smallest width of chip first is causing some problems
on boards with a single 16bit device.

The problem seems to be the jedec_match() is truncating
the device-id read from the table to match against the
one read from the hardware, causing a match against the
partial id of some chips with 16bit IDs (such as the
SST39LF160)

This fixes things for my own board, but something may
need to be done if the same problem is exhibited for
chips with an 8bit ID

Signed-off-by: default avatarBen Dooks <ben@simtec.co.uk>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent eeada24d

drivers/mtd/chips/jedec_probe.c

+11 −1
Original line number Diff line number Diff line 
/* 

   Common Flash Interface probe code.

   (C) 2000 Red Hat. GPL'd.

   $Id: jedec_probe.c,v 1.61 2004/11/19 20:52:16 thayne Exp $

   $Id: jedec_probe.c,v 1.62 2005/02/14 16:27:34 bjd Exp $

   See JEDEC (http://www.jedec.org/) standard JESD21C (section 3.5)

   for the standard this probe goes back to.
@@ -1856,6 +1856,16 @@ static inline int jedec_match( __u32 base, 
	case CFI_DEVICETYPE_X8:

		mfr = (__u8)finfo->mfr_id;

		id = (__u8)finfo->dev_id;



		/* bjd: it seems that if we do this, we can end up

		 * detecting 16bit flashes as an 8bit device, even though

		 * there aren't.

		 */

		if (finfo->dev_id > 0xff) {

			DEBUG( MTD_DEBUG_LEVEL3, "%s(): ID is not 8bit\n",

			       __func__);

			goto match_done;

		}

		break;

	case CFI_DEVICETYPE_X16:

		mfr = (__u16)finfo->mfr_id;