Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0092d3ed authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher
Browse files

drm/amdgpu: set metadata pointer to NULL after freeing. 



Without this there was a double free of the metadata,
which ended up freeing the fd table for me here, and taking
out the machine more often than not.

I reproduced with X.org + modesetting DDX + latest llvm/mesa,
also required using dri3.

Cc: stable@vger.kernel.org
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ea996978

drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

+1 −0
Original line number Diff line number Diff line
@@ -541,6 +541,7 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata, 
	if (!metadata_size) {

		if (bo->metadata_size) {

			kfree(bo->metadata);

			bo->metadata = NULL;

			bo->metadata_size = 0;

		}

		return 0;