Commit ffef7779 authored Jan 17, 2023 by Khazhismel Kumykov Committed by Greg Kroah-Hartman Jan 24, 2023

gsmi: fix null-deref in gsmi_get_variable



commit a769b05eeed7accc4019a1ed9799dd72067f1ce8 upstream.

We can get EFI variables without fetching the attribute, so we must
allow for that in gsmi.

commit 859748255b43 ("efi: pstore: Omit efivars caching EFI varstore
access layer") added a new get_variable call with attr=NULL, which
triggers panic in gsmi.

Fixes: 74c5b31c ("driver: Google EFI SMI")
Cc: stable <stable@kernel.org>
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
Link: https://lore.kernel.org/r/20230118010212.1268474-1-khazhy@google.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b4461af0

drivers/firmware/google/gsmi.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -359,6 +359,7 @@ static efi_status_t gsmi_get_variable(efi_char16_t *name,
		memcpy(data, gsmi_dev.data_buf->start, *data_size);

		/* All variables are have the following attributes */
		if (attr)
		*attr = EFI_VARIABLE_NON_VOLATILE \|
		EFI_VARIABLE_BOOTSERVICE_ACCESS \|
		EFI_VARIABLE_RUNTIME_ACCESS;