Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffe6ad17 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Greg Kroah-Hartman
Browse files

clk: cdce925: check return value of kasprintf() 



[ Upstream commit bb7d09ddbf361d51eae46f38e7c8a2b85914ea2a ]

kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: 19fbbbbc ("Add TI CDCE925 I2C controlled clock synthesizer driver")
Depends-on: e665f029 ("clk: Convert to using %pOFn instead of device_node.name")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20230530093913.1656095-3-claudiu.beznea@microchip.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5f13d670

drivers/clk/clk-cdce925.c

+12 −0
Original line number Diff line number Diff line
@@ -705,6 +705,10 @@ static int cdce925_probe(struct i2c_client *client, 
	for (i = 0; i < data->chip_info->num_plls; ++i) {

		pll_clk_name[i] = kasprintf(GFP_KERNEL, "%pOFn.pll%d",

			client->dev.of_node, i);

		if (!pll_clk_name[i]) {

			err = -ENOMEM;

			goto error;

		}

		init.name = pll_clk_name[i];

		data->pll[i].chip = data;

		data->pll[i].hw.init = &init;
@@ -746,6 +750,10 @@ static int cdce925_probe(struct i2c_client *client, 
	init.num_parents = 1;

	init.parent_names = &parent_name; /* Mux Y1 to input */

	init.name = kasprintf(GFP_KERNEL, "%pOFn.Y1", client->dev.of_node);

	if (!init.name) {

		err = -ENOMEM;

		goto error;

	}

	data->clk[0].chip = data;

	data->clk[0].hw.init = &init;

	data->clk[0].index = 0;
@@ -764,6 +772,10 @@ static int cdce925_probe(struct i2c_client *client, 
	for (i = 1; i < data->chip_info->num_outputs; ++i) {

		init.name = kasprintf(GFP_KERNEL, "%pOFn.Y%d",

			client->dev.of_node, i+1);

		if (!init.name) {

			err = -ENOMEM;

			goto error;

		}

		data->clk[i].chip = data;

		data->clk[i].hw.init = &init;

		data->clk[i].index = i;