Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffd1ef1e authored by Steve French's avatar Steve French
Browse files

smb3: display security information in /proc/fs/cifs/DebugData more accurately 



When the server required encryption (but we didn't connect to it with the
"seal" mount option) we weren't displaying in /proc/fs/cifs/DebugData that
the tcon for that share was encrypted. Similarly we were not displaying
that signing was required when ses->sign was enabled (we only
checked ses->server->sign).  This makes it easier to debug when in
fact the connection is signed (or sealed), whether for performance
or security questions.

Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Reviewed-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
parent 2b53b929

fs/cifs/cifs_debug.c

+7 −1
Original line number Diff line number Diff line
@@ -115,7 +115,9 @@ static void cifs_debug_tcon(struct seq_file *m, struct cifs_tcon *tcon) 
		seq_puts(m, " type: CDROM ");

	else

		seq_printf(m, " type: %d ", dev_type);

	if (tcon->seal)

	if ((tcon->seal) ||

	    (tcon->ses->session_flags & SMB2_SESSION_FLAG_ENCRYPT_DATA) ||

	    (tcon->share_flags & SHI1005_FLAGS_ENCRYPT_DATA))

		seq_printf(m, " Encrypted");

	if (tcon->nocase)

		seq_printf(m, " nocase");
@@ -371,6 +373,10 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v) 
				atomic_read(&server->in_send),

				atomic_read(&server->num_waiters));

#endif

			if (ses->session_flags & SMB2_SESSION_FLAG_ENCRYPT_DATA)

				seq_puts(m, " encrypted");

			if (ses->sign)

				seq_puts(m, " signed");



			seq_puts(m, "\n\tShares:");

			j = 0;