Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fee929ba authored by Evgeny Kalugin's avatar Evgeny Kalugin Committed by Ingo Molnar
Browse files

efi/pstore: Return error code (if any) from efi_pstore_write() 



For some reason return value from actual variable setting was ignored.
With this change error code get transferred upwards through call stack.

Signed-off-by: default avatarEvgeny Kalugin <evgeny.kalugin@intel.com>
Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20170404160245.27812-9-ard.biesheuvel@linaro.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 6e7300cf

drivers/firmware/efi/efi-pstore.c

+3 −3
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ static int efi_pstore_write(enum pstore_type_id type, 
	for (i = 0; i < DUMP_NAME_LEN; i++)

		efi_name[i] = name[i];



	efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,

	ret = efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,

				    !pstore_cannot_block_path(reason),

				    size, psi->buf);