Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fec17cb2 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by Herbert Xu
Browse files

crypto: rsa-pkcs1pad - use constant time memory comparison for MACs 



Otherwise, we enable all sorts of forgeries via timing attack.

Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Suggested-by: default avatarStephan Müller <smueller@chronox.de>
Cc: stable@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ffe55266

crypto/rsa-pkcs1pad.c

+1 −1
Original line number Diff line number Diff line
@@ -490,7 +490,7 @@ static int pkcs1pad_verify_complete(struct akcipher_request *req, int err) 
		goto done;

	pos++;



	if (memcmp(out_buf + pos, digest_info->data, digest_info->size))

	if (crypto_memneq(out_buf + pos, digest_info->data, digest_info->size))

		goto done;



	pos += digest_info->size;