Commit fe8ecccc authored Oct 20, 2018 by Quentin Monnet Committed by Daniel Borkmann Oct 21, 2018

tools: bpftool: fix completion for "bpftool map update"



When trying to complete "bpftool map update" commands, the call to
printf would print an error message that would show on the command line
if no map is found to complete the command line.

Fix it by making sure we have map ids to complete the line with, before
we try to print something.

Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 06ee9da6

tools/bpf/bpftool/bash-completion/bpftool

+1 −1

Original line number	Diff line number	Diff line
		@@ -143,7 +143,7 @@ _bpftool_map_update_map_type()
		local type
		type=$(bpftool -jp map show $keyword $ref \| \
		command sed -n 's/."type": "$.$",$/\1/p')
		printf $type
		[[ -n $type ]] && printf $type
		}

		_bpftool_map_update_get_id()