Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe5c3b69 authored by Kees Cook's avatar Kees Cook Committed by Thomas Gleixner
Browse files

kthread: Convert callback to use from_timer() 



In preparation for unconditionally passing the struct timer_list pointer
to all timer callbacks, switch kthread to use from_timer() and pass the
timer pointer explicitly.

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: linux-mips@linux-mips.org
Cc: Len Brown <len.brown@intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: linux1394-devel@lists.sourceforge.net
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: linux-s390@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Ursula Braun <ubraun@linux.vnet.ibm.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Harish Patil <harish.patil@cavium.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Manish Chopra <manish.chopra@cavium.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-pm@vger.kernel.org
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Mark Gross <mark.gross@intel.com>
Cc: linux-watchdog@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Michael Reed <mdr@sgi.com>
Cc: netdev@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lkml.kernel.org/r/1507159627-127660-13-git-send-email-keescook@chromium.org
parent 8ede369b

include/linux/kthread.h

+5 −5
Original line number Original line Diff line number Diff line
@@ -75,7 +75,7 @@ extern int tsk_fork_get_node(struct task_struct *tsk); 
 */

 */

struct kthread_work;

struct kthread_work;

typedef void (*kthread_work_func_t)(struct kthread_work *work);

typedef void (*kthread_work_func_t)(struct kthread_work *work);

void kthread_delayed_work_timer_fn(unsigned long __data);

void kthread_delayed_work_timer_fn(struct timer_list *t);





enum {

enum {

	KTW_FREEZABLE		= 1 << 0,	/* freeze during suspend */

	KTW_FREEZABLE		= 1 << 0,	/* freeze during suspend */
@@ -116,8 +116,8 @@ struct kthread_delayed_work { 




#define KTHREAD_DELAYED_WORK_INIT(dwork, fn) {				\

#define KTHREAD_DELAYED_WORK_INIT(dwork, fn) {				\

	.work = KTHREAD_WORK_INIT((dwork).work, (fn)),			\

	.work = KTHREAD_WORK_INIT((dwork).work, (fn)),			\

	.timer = __TIMER_INITIALIZER(kthread_delayed_work_timer_fn,	\

	.timer = __TIMER_INITIALIZER((TIMER_FUNC_TYPE)kthread_delayed_work_timer_fn,\

				     (unsigned long)&(dwork),		\

				     (TIMER_DATA_TYPE)&(dwork.timer),	\

				     TIMER_IRQSAFE),			\

				     TIMER_IRQSAFE),			\

	}

	}
@@ -164,8 +164,8 @@ extern void __kthread_init_worker(struct kthread_worker *worker, 
	do {								\

	do {								\

		kthread_init_work(&(dwork)->work, (fn));		\

		kthread_init_work(&(dwork)->work, (fn));		\

		__setup_timer(&(dwork)->timer,				\

		__setup_timer(&(dwork)->timer,				\

			      kthread_delayed_work_timer_fn,		\

			      (TIMER_FUNC_TYPE)kthread_delayed_work_timer_fn,\

			      (unsigned long)(dwork),			\

			      (TIMER_DATA_TYPE)&(dwork)->timer,		\

			      TIMER_IRQSAFE);				\

			      TIMER_IRQSAFE);				\

	} while (0)

	} while (0)

kernel/kthread.c

+4 −6
Original line number Original line Diff line number Diff line
@@ -798,15 +798,14 @@ EXPORT_SYMBOL_GPL(kthread_queue_work); 
/**

/**

 * kthread_delayed_work_timer_fn - callback that queues the associated kthread

 * kthread_delayed_work_timer_fn - callback that queues the associated kthread

 *	delayed work when the timer expires.

 *	delayed work when the timer expires.

 * @__data: pointer to the data associated with the timer

 * @t: pointer to the expired timer

 *

 *

 * The format of the function is defined by struct timer_list.

 * The format of the function is defined by struct timer_list.

 * It should have been called from irqsafe timer with irq already off.

 * It should have been called from irqsafe timer with irq already off.

 */

 */

void kthread_delayed_work_timer_fn(unsigned long __data)

void kthread_delayed_work_timer_fn(struct timer_list *t)

{

{

	struct kthread_delayed_work *dwork =

	struct kthread_delayed_work *dwork = from_timer(dwork, t, timer);

		(struct kthread_delayed_work *)__data;

	struct kthread_work *work = &dwork->work;

	struct kthread_work *work = &dwork->work;

	struct kthread_worker *worker = work->worker;

	struct kthread_worker *worker = work->worker;
@@ -837,8 +836,7 @@ void __kthread_queue_delayed_work(struct kthread_worker *worker, 
	struct timer_list *timer = &dwork->timer;

	struct timer_list *timer = &dwork->timer;

	struct kthread_work *work = &dwork->work;

	struct kthread_work *work = &dwork->work;





	WARN_ON_ONCE(timer->function != kthread_delayed_work_timer_fn ||

	WARN_ON_ONCE(timer->function != (TIMER_FUNC_TYPE)kthread_delayed_work_timer_fn);

		     timer->data != (unsigned long)dwork);





	/*

	/*

	 * If @delay is 0, queue @dwork->work immediately.  This is for

	 * If @delay is 0, queue @dwork->work immediately.  This is for