Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdf290fd authored by Matthieu CASTET's avatar Matthieu CASTET Committed by Greg Kroah-Hartman
Browse files

[PATCH] UEAGLE : cmv name bug (was cosmetic) 



this patch correct a possible bug with cmv_name being static. If there
is 2 modems and the driver is scheduled when filling cmv_name this could
result with garbage in cmv_name. We allocate cmv_name on the stack but
with a small size in order to avoid that.

Signed-off-by: default avatarMatthieu CASTET <castet.matthieu@free.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e40abaf6

drivers/usb/atm/ueagle-atm.c

+1 −1
Original line number Diff line number Diff line
@@ -1013,7 +1013,7 @@ static int request_cmvs(struct uea_softc *sc, 
	int ret, size;

	u8 *data;

	char *file;

	static char cmv_name[256] = FW_DIR;

	char cmv_name[FIRMWARE_NAME_MAX]; /* 30 bytes stack variable */



	if (cmv_file[sc->modem_index] == NULL) {

		if (UEA_CHIP_VERSION(sc) == ADI930)