Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdac9448 authored by Alexandre Belloni's avatar Alexandre Belloni Committed by Shuah Khan
Browse files

selftests: rtc: rtctest: fix alarm tests 



Return values for select are not checked properly and timeouts may not be
detected.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: default avatarShuah Khan <shuah@kernel.org>
parent bfeffd15

tools/testing/selftests/rtc/rtctest.c

+2 −5
Original line number Diff line number Diff line
@@ -145,15 +145,12 @@ TEST_F(rtc, alarm_alm_set) { 


	rc = select(self->fd + 1, &readfds, NULL, NULL, &tv);

	ASSERT_NE(-1, rc);

	EXPECT_NE(0, rc);

	ASSERT_NE(0, rc);



	/* Disable alarm interrupts */

	rc = ioctl(self->fd, RTC_AIE_OFF, 0);

	ASSERT_NE(-1, rc);



	if (rc == 0)

		return;



	rc = read(self->fd, &data, sizeof(unsigned long));

	ASSERT_NE(-1, rc);

	TH_LOG("data: %lx", data);
@@ -202,7 +199,7 @@ TEST_F(rtc, alarm_wkalm_set) { 


	rc = select(self->fd + 1, &readfds, NULL, NULL, &tv);

	ASSERT_NE(-1, rc);

	EXPECT_NE(0, rc);

	ASSERT_NE(0, rc);



	rc = read(self->fd, &data, sizeof(unsigned long));

	ASSERT_NE(-1, rc);