Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fda2d072 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

net: netsec: fix error handling in netsec_register_mdio() 



[ Upstream commit 94423589689124e8cd145b38a1034be7f25835b2 ]

If phy_device_register() fails, phy_device_free() need be called to
put refcount, so memory of phy device and device name can be freed
in callback function.

If get_phy_device() fails, mdiobus_unregister() need be called,
or it will cause warning in mdiobus_free() and kobject is leaked.

Fixes: 533dd11a ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221019064104.3228892-1-yangyingliang@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 24b129ae

drivers/net/ethernet/socionext/netsec.c

+2 −0
Original line number Diff line number Diff line
@@ -1936,11 +1936,13 @@ static int netsec_register_mdio(struct netsec_priv *priv, u32 phy_addr) 
			ret = PTR_ERR(priv->phydev);

			dev_err(priv->dev, "get_phy_device err(%d)\n", ret);

			priv->phydev = NULL;

			mdiobus_unregister(bus);

			return -ENODEV;

		}



		ret = phy_device_register(priv->phydev);

		if (ret) {

			phy_device_free(priv->phydev);

			mdiobus_unregister(bus);

			dev_err(priv->dev,

				"phy_device_register err(%d)\n", ret);