Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fce08155 authored by Justin Chen's avatar Justin Chen Committed by Greg Kroah-Hartman
Browse files

net: phy: broadcom: stub c45 read/write for 54810 



commit 096516d092d54604d590827d05b1022c8f326639 upstream.

The 54810 does not support c45. The mmd_phy_indirect accesses return
arbirtary values leading to odd behavior like saying it supports EEE
when it doesn't. We also see that reading/writing these non-existent
MMD registers leads to phy instability in some cases.

Fixes: b14995ac ("net: phy: broadcom: Add BCM54810 PHY entry")
Signed-off-by: default avatarJustin Chen <justin.chen@broadcom.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/1691901708-28650-1-git-send-email-justin.chen@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
[florian: resolved conflicts in 5.4]
Signed-off-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e91d5ace

drivers/net/phy/broadcom.c

+13 −0
Original line number Diff line number Diff line
@@ -425,6 +425,17 @@ static int bcm5482_read_status(struct phy_device *phydev) 
	return err;

}



static int bcm54810_read_mmd(struct phy_device *phydev, int devnum, u16 regnum)

{

	return -EOPNOTSUPP;

}



static int bcm54810_write_mmd(struct phy_device *phydev, int devnum, u16 regnum,

			      u16 val)

{

	return -EOPNOTSUPP;

}



static int bcm5481_config_aneg(struct phy_device *phydev)

{

	struct device_node *np = phydev->mdio.dev.of_node;
@@ -696,6 +707,8 @@ static struct phy_driver broadcom_drivers[] = { 
	.phy_id_mask    = 0xfffffff0,

	.name           = "Broadcom BCM54810",

	/* PHY_GBIT_FEATURES */

	.read_mmd	= bcm54810_read_mmd,

	.write_mmd	= bcm54810_write_mmd,

	.config_init    = bcm54xx_config_init,

	.config_aneg    = bcm5481_config_aneg,

	.ack_interrupt  = bcm_phy_ack_intr,