Commit fcc5c4a2 authored Apr 21, 2009 by Rusty Russell Committed by Ingo Molnar Apr 21, 2009

x86: avoid theoretical spurious NMI backtraces with CONFIG_CPUMASK_OFFSTACK=y



In theory (though not shown in practice) alloc_cpumask_var() doesn't zero
memory, so CPUs might print an "NMI backtrace for cpu %d" once on boot.

(Bug introduced in fcef8576).

[ Impact: avoid theoretical syslog noise in rare configs ]

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <alpine.DEB.2.00.0904202113520.10097@gandalf.stny.rr.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 2f537a9f

arch/x86/kernel/apic/nmi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -138,7 +138,7 @@ int __init check_nmi_watchdog(void)
		if (!prev_nmi_count)
		goto error;

		alloc_cpumask_var(&backtrace_mask, GFP_KERNEL);
		alloc_cpumask_var(&backtrace_mask, GFP_KERNEL\|__GFP_ZERO);
		printk(KERN_INFO "Testing NMI watchdog ... ");

		#ifdef CONFIG_SMP