Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcaff9bc authored by Liang He's avatar Liang He Committed by Greg Kroah-Hartman
Browse files

clk: oxnas: Hold reference returned by of_get_parent() 



[ Upstream commit 1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f ]

In oxnas_stdclk_probe(), we need to hold the reference returned by
of_get_parent() and use it to call of_node_put() for refcount
balance.

Fixes: 0bbd72b4 ("clk: Add Oxford Semiconductor OXNAS Standard Clocks")
Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220628143155.170550-1-windhl@126.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ad3a0569

drivers/clk/clk-oxnas.c

+4 −2
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static const struct of_device_id oxnas_stdclk_dt_ids[] = { 


static int oxnas_stdclk_probe(struct platform_device *pdev)

{

	struct device_node *np = pdev->dev.of_node;

	struct device_node *np = pdev->dev.of_node, *parent_np;

	const struct oxnas_stdclk_data *data;

	const struct of_device_id *id;

	struct regmap *regmap;
@@ -219,7 +219,9 @@ static int oxnas_stdclk_probe(struct platform_device *pdev) 
		return -ENODEV;

	data = id->data;



	regmap = syscon_node_to_regmap(of_get_parent(np));

	parent_np = of_get_parent(np);

	regmap = syscon_node_to_regmap(parent_np);

	of_node_put(parent_np);

	if (IS_ERR(regmap)) {

		dev_err(&pdev->dev, "failed to have parent regmap\n");

		return PTR_ERR(regmap);