Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc96df16 authored by Dexuan Cui's avatar Dexuan Cui Committed by Sasha Levin
Browse files

Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels 



Before 98f4c651, we returned zeros for unopened channels.
With 98f4c651, we started to return random on-stack values.

We'd better return -EINVAL instead.

Fixes: 98f4c651 ("hv: move ringbuffer bus attributes to dev_groups")
Cc: stable@vger.kernel.org
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: default avatarDexuan Cui <decui@microsoft.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c629421a

drivers/hv/vmbus_drv.c

+20 −0
Original line number Diff line number Diff line
@@ -316,6 +316,8 @@ static ssize_t out_intr_mask_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound);

	return sprintf(buf, "%d\n", outbound.current_interrupt_mask);

}
@@ -329,6 +331,8 @@ static ssize_t out_read_index_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound);

	return sprintf(buf, "%d\n", outbound.current_read_index);

}
@@ -343,6 +347,8 @@ static ssize_t out_write_index_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound);

	return sprintf(buf, "%d\n", outbound.current_write_index);

}
@@ -357,6 +363,8 @@ static ssize_t out_read_bytes_avail_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound);

	return sprintf(buf, "%d\n", outbound.bytes_avail_toread);

}
@@ -371,6 +379,8 @@ static ssize_t out_write_bytes_avail_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound);

	return sprintf(buf, "%d\n", outbound.bytes_avail_towrite);

}
@@ -384,6 +394,8 @@ static ssize_t in_intr_mask_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound);

	return sprintf(buf, "%d\n", inbound.current_interrupt_mask);

}
@@ -397,6 +409,8 @@ static ssize_t in_read_index_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound);

	return sprintf(buf, "%d\n", inbound.current_read_index);

}
@@ -410,6 +424,8 @@ static ssize_t in_write_index_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound);

	return sprintf(buf, "%d\n", inbound.current_write_index);

}
@@ -424,6 +440,8 @@ static ssize_t in_read_bytes_avail_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound);

	return sprintf(buf, "%d\n", inbound.bytes_avail_toread);

}
@@ -438,6 +456,8 @@ static ssize_t in_write_bytes_avail_show(struct device *dev, 


	if (!hv_dev->channel)

		return -ENODEV;

	if (hv_dev->channel->state != CHANNEL_OPENED_STATE)

		return -EINVAL;

	hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound);

	return sprintf(buf, "%d\n", inbound.bytes_avail_towrite);

}