Commit fc92a14f authored Feb 02, 2022 by Gal Pressman Committed by Greg Kroah-Hartman Mar 02, 2022

net/mlx5e: Fix wrong return value on ioctl EEPROM query failure



commit 0b89429722353d112f8b8b29ca397e95fa994d27 upstream.

The ioctl EEPROM query wrongly returns success on read failures, fix
that by returning the appropriate error code.

Fixes: bb64143e ("net/mlx5e: Add ethtool support for dump module EEPROM")
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3cbf1f98

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1683,7 +1683,7 @@ static int mlx5e_get_module_eeprom(struct net_device *netdev,
		if (size_read < 0) {
		netdev_err(priv->netdev, "%s: mlx5_query_eeprom failed:0x%x\n",
		__func__, size_read);
		return 0;
		return size_read;
		}

		i += size_read;