Commit fc4b3fa7 authored Jul 15, 2012 by Hans-Frieder Vogt Committed by Mauro Carvalho Chehab Jul 30, 2012

[media] rtl2832.c: minor cleanup



The current formulation of the bw_params loop uses the counter j as an
index for the first dimension of the bw_params array which is later
incremented by the variable i. It is evaluated correctly only, because j
is initialized to 0 at the beginning of the loop. I think that
explicitly using the index 0 better reflects the intent of the
expression.

Signed-off-by: Hans-Frieder Vogt <hfvogt@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 26ff6313

drivers/media/dvb/frontends/rtl2832.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -589,7 +589,7 @@ static int rtl2832_set_frontend(struct dvb_frontend *fe)
		return -EINVAL;
		}

		for (j = 0; j < sizeof(bw_params[j]); j++) {
		for (j = 0; j < sizeof(bw_params[0]); j++) {
		ret = rtl2832_wr_regs(priv, 0x1c+j, 1, &bw_params[i][j], 1);
		if (ret)
		goto err;