Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc16c25f authored by Jeff Garzik's avatar Jeff Garzik
Browse files

[libata] ACPI: remove needless ->qc_issue hook existence test 



All drivers must implement this hook, otherwise ATA commands would go
nowhere (and a lot of other oopsen would appear as well).

Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent ea34e45a

drivers/ata/libata-acpi.c

+22 −29
Original line number Diff line number Diff line
@@ -455,6 +455,9 @@ static void taskfile_load_raw(struct ata_port *ap, 
				struct ata_device *atadev,

				const struct taskfile_array *gtf)

{

	struct ata_taskfile tf;

	unsigned int err;



	if (ata_msg_probe(ap))

		ata_dev_printk(atadev, KERN_DEBUG, "%s: (0x1f1-1f7): hex: "

			"%02x %02x %02x %02x %02x %02x %02x\n",
@@ -467,10 +470,6 @@ static void taskfile_load_raw(struct ata_port *ap, 
	    && (gtf->tfa[6] == 0))

		return;



	if (ap->ops->qc_issue) {

		struct ata_taskfile tf;

		unsigned int err;



	ata_tf_init(atadev, &tf);



	/* convert gtf to tf */
@@ -490,12 +489,6 @@ static void taskfile_load_raw(struct ata_port *ap, 
		ata_dev_printk(atadev, KERN_ERR,

			"%s: ata_exec_internal failed: %u\n",

			__FUNCTION__, err);

	} else

		if (ata_msg_warn(ap))

			ata_dev_printk(atadev, KERN_WARNING,

				"%s: SATA driver is missing qc_issue function"

				" entry points\n",

				__FUNCTION__);

}



/**