Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbe8758f authored by Olof Johansson's avatar Olof Johansson
Browse files

Revert "ARM: dts: nomadik: Fix polarity of SPI CS"



This reverts commit fa946356.

Per Linus Walleij:

Dear ARM SoC maintainers,

can you please revert this patch. It was the wrong solution to the
wrong problem, and I must have acted in stress. Andrey fixed the
real bug in a proper way in these commits:

commit e5545c94
"gpio: of: Check propname before applying "cs-gpios" quirks"
commit 7ce40277
"gpio: of: Check for "spi-cs-high" in child instead of parent node"

Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
parent c983f102
Loading
Loading
Loading
Loading
+4 −5
Original line number Diff line number Diff line
@@ -213,13 +213,12 @@
		gpio-sck = <&gpio0 5 GPIO_ACTIVE_HIGH>;
		gpio-mosi = <&gpio0 4 GPIO_ACTIVE_HIGH>;
		/*
		 * This chipselect is active high. Just setting the flags
		 * to GPIO_ACTIVE_HIGH is not enough for the SPI DT bindings,
		 * it will be ignored, only the special "spi-cs-high" flag
		 * really counts.
		 * It's not actually active high, but the frameworks assume
		 * the polarity of the passed-in GPIO is "normal" (active
		 * high) then actively drives the line low to select the
		 * chip.
		 */
		cs-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
		spi-cs-high;
		num-chipselects = <1>;

		/*