Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbc318af authored by Alexandre Belloni's avatar Alexandre Belloni Committed by Felipe Balbi
Browse files

usb: gadget: udc: lpc32xx: allocate descriptor with GFP_ATOMIC 



Gadget drivers may queue request in interrupt context. This would lead to
a descriptor allocation in that context. In that case we would hit
BUG_ON(in_interrupt()) in __get_vm_area_node.

Also remove the unnecessary cast.

Acked-by: default avatarSylvain Lemieux <slemieux.tyco@gmail.com>
Tested-by: default avatarJames Grant <jamesg@zaltys.org>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 62fd0e0a

drivers/usb/gadget/udc/lpc32xx_udc.c

+1 −2
Original line number Diff line number Diff line
@@ -937,8 +937,7 @@ static struct lpc32xx_usbd_dd_gad *udc_dd_alloc(struct lpc32xx_udc *udc) 
	dma_addr_t			dma;

	struct lpc32xx_usbd_dd_gad	*dd;



	dd = (struct lpc32xx_usbd_dd_gad *) dma_pool_alloc(

			udc->dd_cache, (GFP_KERNEL | GFP_DMA), &dma);

	dd = dma_pool_alloc(udc->dd_cache, GFP_ATOMIC | GFP_DMA, &dma);

	if (dd)

		dd->this_dma = dma;