Commit fb7b73cd authored Oct 28, 2021 by Bixuan Cui Committed by Greg Kroah-Hartman Nov 17, 2021

powerpc/44x/fsp2: add missing of_node_put



[ Upstream commit 290fe8aa69ef5c51c778c0bb33f8ef0181c769f5 ]

Early exits from for_each_compatible_node() should decrement the
node reference counter.  Reported by Coccinelle:

./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function
"for_each_compatible_node" should have of_node_put() before return
around line 218.

Fixes: 7813043e ("powerpc/44x/fsp2: Add irq error handlers")
Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1635406102-88719-1-git-send-email-cuibixuan@linux.alibaba.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d3dd1a05

arch/powerpc/platforms/44x/fsp2.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -208,6 +208,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler)
		if (irq == NO_IRQ) {
		pr_err("device tree node %pOFn is missing a interrupt",
		np);
		of_node_put(np);
		return;
		}

		@@ -215,6 +216,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler)
		if (rc) {
		pr_err("fsp_of_probe: request_irq failed: np=%pOF rc=%d",
		np, rc);
		of_node_put(np);
		return;
		}
		}