Commit fb381e60 authored Jul 08, 2019 by Jacob Keller Committed by Jeff Kirsher Aug 01, 2019

fm10k: reduce the scope of the tx_buffer variable



The tx_buffer local variable in the function fm10k_clean_tx_ring is not
used except inside a smaller block scope. Reduce the scope to its point
of use.

This was detected by cppcheck and resolves the following style warning
produced by that tool:

[fm10k_netdev.c:179]: (style) The scope of the variable 'tx_buffer' can
be reduced.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 7a432d57

drivers/net/ethernet/intel/fm10k/fm10k_netdev.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -169,7 +169,6 @@ void fm10k_unmap_and_free_tx_resource(struct fm10k_ring *ring,
		**/
		static void fm10k_clean_tx_ring(struct fm10k_ring *tx_ring)
		{
		struct fm10k_tx_buffer *tx_buffer;
		unsigned long size;
		u16 i;

		@@ -179,7 +178,8 @@ static void fm10k_clean_tx_ring(struct fm10k_ring *tx_ring)

		/* Free all the Tx ring sk_buffs */
		for (i = 0; i < tx_ring->count; i++) {
		tx_buffer = &tx_ring->tx_buffer[i];
		struct fm10k_tx_buffer *tx_buffer = &tx_ring->tx_buffer[i];

		fm10k_unmap_and_free_tx_resource(tx_ring, tx_buffer);
		}