Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb1dd794 authored by Syam Sidhardhan's avatar Syam Sidhardhan Committed by Herbert Xu
Browse files

crypto: bfin_crc - Fix possible NULL pointer dereference 



If we define dev_dbg(), then there is a possible NULL pointer
dereference.

Signed-off-by: default avatarSyam Sidhardhan <s.syam@samsung.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent a84fb791

drivers/crypto/bfin_crc.c

+3 −3
Original line number Diff line number Diff line
@@ -151,7 +151,7 @@ static int bfin_crypto_crc_init(struct ahash_request *req) 
	struct bfin_crypto_crc_reqctx *ctx = ahash_request_ctx(req);

	struct bfin_crypto_crc *crc;



	dev_dbg(crc->dev, "crc_init\n");

	dev_dbg(ctx->crc->dev, "crc_init\n");

	spin_lock_bh(&crc_list.lock);

	list_for_each_entry(crc, &crc_list.dev_list, list) {

		crc_ctx->crc = crc;
@@ -160,7 +160,7 @@ static int bfin_crypto_crc_init(struct ahash_request *req) 
	spin_unlock_bh(&crc_list.lock);



	if (sg_count(req->src) > CRC_MAX_DMA_DESC) {

		dev_dbg(crc->dev, "init: requested sg list is too big > %d\n",

		dev_dbg(ctx->crc->dev, "init: requested sg list is too big > %d\n",

			CRC_MAX_DMA_DESC);

		return -EINVAL;

	}
@@ -175,7 +175,7 @@ static int bfin_crypto_crc_init(struct ahash_request *req) 
	/* init crc results */

	put_unaligned_le32(crc_ctx->key, req->result);



	dev_dbg(crc->dev, "init: digest size: %d\n",

	dev_dbg(ctx->crc->dev, "init: digest size: %d\n",

		crypto_ahash_digestsize(tfm));



	return bfin_crypto_crc_init_hw(crc, crc_ctx->key);