Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fad137c4 authored by Jerome Brunet's avatar Jerome Brunet Committed by David S. Miller
Browse files

net: phy: meson-gxl: clean-up gxl variant driver 



The purpose of this change is to align the gxl and g12a driver
declaration.

Like on the g12a variant, remove genphy_aneg_done() from the driver
declaration as the net phy framework will default to it anyway.

Also, the gxl phy id should be an exact match as well, so let's change
this and use the macro provided.

Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5c3407ab

drivers/net/phy/meson-gxl.c

+2 −4
Original line number Diff line number Diff line
@@ -224,14 +224,12 @@ static int meson_gxl_config_intr(struct phy_device *phydev) 


static struct phy_driver meson_gxl_phy[] = {

	{

		.phy_id		= 0x01814400,

		.phy_id_mask	= 0xfffffff0,

		PHY_ID_MATCH_EXACT(0x01814400),

		.name		= "Meson GXL Internal PHY",

		.features	= PHY_BASIC_FEATURES,

		.flags		= PHY_IS_INTERNAL,

		.soft_reset     = genphy_soft_reset,

		.config_init	= meson_gxl_config_init,

		.aneg_done      = genphy_aneg_done,

		.read_status	= meson_gxl_read_status,

		.ack_interrupt	= meson_gxl_ack_interrupt,

		.config_intr	= meson_gxl_config_intr,
@@ -251,7 +249,7 @@ static struct phy_driver meson_gxl_phy[] = { 
};



static struct mdio_device_id __maybe_unused meson_gxl_tbl[] = {

	{ 0x01814400, 0xfffffff0 },

	{ PHY_ID_MATCH_VENDOR(0x01814400) },

	{ PHY_ID_MATCH_VENDOR(0x01803301) },

	{ }

};