Commit faae54ad authored Jan 24, 2019 by Chaitanya Tata Committed by Johannes Berg Jan 25, 2019

cfg80211: reg: remove warn_on for a normal case



If there are simulatenous queries of regdb, then there might be a case
where multiple queries can trigger request_firmware_no_wait and can have
parallel callbacks being executed asynchronously. In this scenario we
might hit the WARN_ON.

So remove the warn_on, as the code already handles multiple callbacks
gracefully.

Signed-off-by: Chaitanya Tata <chaitanya.tata@bluwireless.co.uk>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 7c53eb5d

net/wireless/reg.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -1024,8 +1024,13 @@ static void regdb_fw_cb(const struct firmware fw, void context)
		}

		rtnl_lock();
		if (WARN_ON(regdb && !IS_ERR(regdb))) {
		/* just restore and free new db */
		if (regdb && !IS_ERR(regdb)) {
		/* negative case - a bug
		* positive case - can happen due to race in case of multiple cb's in
		* queue, due to usage of asynchronous callback
		*
		* Either case, just restore and free new db.
		*/
		} else if (set_error) {
		regdb = ERR_PTR(set_error);
		} else if (fw) {