Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faa08325 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller
Browse files

isdn/hisax: Remove unnecessary parenthesis 



Clang warns when more than one set of parentheses are used for single
conditional statements:

drivers/isdn/hisax/w6692.c:627:30: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
                if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {
                     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
drivers/isdn/hisax/w6692.c:627:30: note: remove extraneous parentheses
around the comparison to silence this warning
                if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {
                    ~                      ^             ~
drivers/isdn/hisax/w6692.c:627:30: note: use '=' to turn this equality
comparison into an assignment
                if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {
                                           ^~
                                           =
1 warning generated.

Remove the parentheses to silence this warning.

Reported-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 713746bb

drivers/isdn/hisax/w6692.c

+1 −1
Original line number Diff line number Diff line
@@ -624,7 +624,7 @@ W6692_l1hw(struct PStack *st, int pr, void *arg) 
		break;

	case (HW_RESET | REQUEST):

		spin_lock_irqsave(&cs->lock, flags);

		if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) {

		if (cs->dc.w6692.ph_state == W_L1IND_DRD) {

			ph_command(cs, W_L1CMD_ECK);

			spin_unlock_irqrestore(&cs->lock, flags);

		} else {