Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa3a419d authored by Wen Yang's avatar Wen Yang Committed by David S. Miller
Browse files

net: xilinx: fix possible object reference leak 



The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1624:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1569, but without a corresponding object release within this function.

Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Cc: Anirudha Sarangi <anirudh@xilinx.com>
Cc: John Linn <John.Linn@xilinx.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: netdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a7fb107b

drivers/net/ethernet/xilinx/xilinx_axienet_main.c

+2 −0
Original line number Diff line number Diff line
@@ -1575,12 +1575,14 @@ static int axienet_probe(struct platform_device *pdev) 
	ret = of_address_to_resource(np, 0, &dmares);

	if (ret) {

		dev_err(&pdev->dev, "unable to get DMA resource\n");

		of_node_put(np);

		goto free_netdev;

	}

	lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares);

	if (IS_ERR(lp->dma_regs)) {

		dev_err(&pdev->dev, "could not map DMA regs\n");

		ret = PTR_ERR(lp->dma_regs);

		of_node_put(np);

		goto free_netdev;

	}

	lp->rx_irq = irq_of_parse_and_map(np, 1);