Commit fa3a03da authored Jul 07, 2019 by Sven Eckelmann Committed by Simon Wunderlich Jul 22, 2019

batman-adv: Fix netlink dumping of all mcast_flags buckets



The bucket variable is only updated outside the loop over the mcast_flags
buckets. It will only be updated during a dumping run when the dumping has
to be interrupted and a new message has to be started.

This could result in repeated or missing entries when the multicast flags
are dumped to userspace.

Fixes: d2d489b7 ("batman-adv: Add inconsistent multicast netlink dump detection")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

parent 5f9e832c

net/batman-adv/multicast.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2303,7 +2303,7 @@ __batadv_mcast_flags_dump(struct sk_buff *msg, u32 portid,

		while (bucket_tmp < hash->size) {
		if (batadv_mcast_flags_dump_bucket(msg, portid, cb, hash,
		*bucket, &idx_tmp))
		bucket_tmp, &idx_tmp))
		break;

		bucket_tmp++;