Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa355bb1 authored by Saeed Mahameed's avatar Saeed Mahameed
Browse files

net/mlx5: FWTrace, Reduce stack usage 



Mark mlx5_tracer_print_trace as noinline as the function only uses 512
bytes on the stack to avoid the following build warning:

drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c:660:13: error: stack frame size of 1032 bytes in function 'mlx5_fw_tracer_handle_traces' [-Werror,-Wframe-larger-than=]

Fixes: 70dd6fdb ("net/mlx5: FW tracer, parse traces and kernel tracing support")
Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 334a306f

drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c

+4 −3
Original line number Original line Diff line number Diff line
@@ -553,7 +553,8 @@ static void mlx5_fw_tracer_save_trace(struct mlx5_fw_tracer *tracer, 
	mutex_unlock(&tracer->st_arr.lock);

	mutex_unlock(&tracer->st_arr.lock);

}

}





static void mlx5_tracer_print_trace(struct tracer_string_format *str_frmt,

static noinline

void mlx5_tracer_print_trace(struct tracer_string_format *str_frmt,

			     struct mlx5_core_dev *dev,

			     struct mlx5_core_dev *dev,

			     u64 trace_timestamp)

			     u64 trace_timestamp)

{

{