Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa0b2dd6 authored by Shuah Khan's avatar Shuah Khan Committed by Greg Kroah-Hartman
Browse files

misc: rtsx: set NULL intfdata when probe fails 



[ Upstream commit f861d36e021e1ac4a0a2a1f6411d623809975d63 ]

rtsx_usb_probe() doesn't call usb_set_intfdata() to null out the
interface pointer when probe fails. This leaves a stale pointer.
Noticed the missing usb_set_intfdata() while debugging an unrelated
invalid DMA mapping problem.

Fix it with a call to usb_set_intfdata(..., NULL).

Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20220429210913.46804-1-skhan@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d232ca0b

drivers/misc/cardreader/rtsx_usb.c

+1 −0
Original line number Diff line number Diff line
@@ -667,6 +667,7 @@ static int rtsx_usb_probe(struct usb_interface *intf, 
	return 0;



out_init_fail:

	usb_set_intfdata(ucr->pusb_intf, NULL);

	usb_free_coherent(ucr->pusb_dev, IOBUF_SIZE, ucr->iobuf,

			ucr->iobuf_dma);

	return ret;