Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9a954ff authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Remove bogus FIXME from SKL wm computation 



We do return an error when the watermark calculation fails, so
the FIXME claiming otherwise is outdated. Remove it.

Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181113172330.26069-2-ville.syrjala@linux.intel.com


Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 099a132b

drivers/gpu/drm/i915/intel_pm.c

+0 −4
Original line number Diff line number Diff line
@@ -5549,10 +5549,6 @@ skl_compute_wm(struct drm_atomic_state *state) 
	 * Note that the DDB allocation above may have added more CRTC's that

	 * weren't otherwise being modified (and set bits in dirty_pipes) if

	 * pipe allocations had to change.

	 *

	 * FIXME:  Now that we're doing this in the atomic check phase, we

	 * should allow skl_update_pipe_wm() to return failure in cases where

	 * no suitable watermark values can be found.

	 */

	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, cstate, i) {

		struct intel_crtc_state *intel_cstate =