Commit f99bc332 authored Jun 17, 2019 by Arnd Bergmann Committed by Oded Gabbay Jun 20, 2019

habanalabs: use u64_to_user_ptr() for reading user pointers

We cannot cast a 64-bit integer to a pointer on 32-bit architectures
without a warning:

drivers/misc/habanalabs/habanalabs_ioctl.c: In function 'debug_coresight':
drivers/misc/habanalabs/habanalabs_ioctl.c:143:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
input = memdup_user((const void __user *) args->input_ptr,

Use the macro that was defined for this purpose.

Fixes: 315bc055 ("habanalabs: add new IOCTL for debug, tracing and profiling")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

parent 6ad805b8

drivers/misc/habanalabs/habanalabs_ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -140,7 +140,7 @@ static int debug_coresight(struct hl_device hdev, struct hl_debug_args args)
		params->op = args->op;

		if (args->input_ptr && args->input_size) {
		input = memdup_user((const void __user *) args->input_ptr,
		input = memdup_user(u64_to_user_ptr(args->input_ptr),
		args->input_size);
		if (IS_ERR(input)) {
		rc = PTR_ERR(input);