Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f937d93a authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Doug Ledford
Browse files

RDMA/uverbs: Declare local function static and add brackets to sizeof 



Commit 57520751 ("IB/SA: Add OPA path record type") introduced
new local function __ib_copy_path_rec_to_user, but didn't limit its
scope. This produces the following sparse warning:

	drivers/infiniband/core/uverbs_marshall.c:99:6: warning:
	symbol '__ib_copy_path_rec_to_user' was not declared. Should it be
	static?

In addition, it used sizeof ... notations instead of sizeof(...), which
is correct in C, but a little bit misleading. Let's change it too.

Fixes: 57520751 ("IB/SA: Add OPA path record type")
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 233c1955

drivers/infiniband/core/uverbs_marshall.c

+4 −4
Original line number Diff line number Diff line
@@ -96,11 +96,11 @@ void ib_copy_qp_attr_to_user(struct ib_uverbs_qp_attr *dst, 
}

EXPORT_SYMBOL(ib_copy_qp_attr_to_user);



void __ib_copy_path_rec_to_user(struct ib_user_path_rec *dst,

static void __ib_copy_path_rec_to_user(struct ib_user_path_rec *dst,

				       struct sa_path_rec *src)

{

	memcpy(dst->dgid, src->dgid.raw, sizeof src->dgid);

	memcpy(dst->sgid, src->sgid.raw, sizeof src->sgid);

	memcpy(dst->dgid, src->dgid.raw, sizeof(src->dgid));

	memcpy(dst->sgid, src->sgid.raw, sizeof(src->sgid));



	dst->dlid		= htons(ntohl(sa_path_get_dlid(src)));

	dst->slid		= htons(ntohl(sa_path_get_slid(src)));