Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9127db9 authored by Kishon Vijay Abraham I's avatar Kishon Vijay Abraham I Committed by Lorenzo Pieralisi
Browse files

PCI: keystone: Cleanup set_dbi_mode() and get_dbi_mode() 



No functional change. Use BIT() macro for DBI_CS2 and cleanup
set_dbi_mode() and get_dbi_mode().

Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent e75043ad

drivers/pci/controller/dwc/pci-keystone.c

+7 −5
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ 
#define LTSSM_EN_VAL		        BIT(0)

#define LTSSM_STATE_MASK		0x1f

#define LTSSM_STATE_L0			0x11

#define DBI_CS2_EN_VAL			0x20

#define DBI_CS2				BIT(5)

#define OB_XLAT_EN_VAL		        BIT(1)



/* Application registers */
@@ -315,11 +315,12 @@ static void ks_pcie_set_dbi_mode(struct keystone_pcie *ks_pcie) 
	u32 val;



	val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);

	ks_pcie_app_writel(ks_pcie, CMD_STATUS, DBI_CS2_EN_VAL | val);

	val |= DBI_CS2;

	ks_pcie_app_writel(ks_pcie, CMD_STATUS, val);



	do {

		val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);

	} while (!(val & DBI_CS2_EN_VAL));

	} while (!(val & DBI_CS2));

}



/**
@@ -333,11 +334,12 @@ static void ks_pcie_clear_dbi_mode(struct keystone_pcie *ks_pcie) 
	u32 val;



	val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);

	ks_pcie_app_writel(ks_pcie, CMD_STATUS, ~DBI_CS2_EN_VAL & val);

	val &= ~DBI_CS2;

	ks_pcie_app_writel(ks_pcie, CMD_STATUS, val);



	do {

		val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);

	} while (val & DBI_CS2_EN_VAL);

	} while (val & DBI_CS2);

}



static void ks_pcie_setup_rc_app_regs(struct keystone_pcie *ks_pcie)