Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8f4bef3 authored by Or Gerlitz's avatar Or Gerlitz Committed by David S. Miller
Browse files

net : sched: cls_api: deal with egdev path only if needed 



When dealing with ingress rule on a netdev, if we did fine through the
conventional path, there's no need to continue into the egdev route,
and we can stop right there.

Not doing so may cause a 2nd rule to be added by the cls api layer
with the ingress being the egdev.

For example, under sriov switchdev scheme, a user rule of VFR A --> VFR B
will end up with two HW rules (1) VF A --> VF B and (2) uplink --> VF B

Fixes: 208c0f4b ('net: sched: use tc_setup_cb_call to call per-block callbacks')
Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1b15ad68

net/sched/cls_api.c

+1 −1
Original line number Diff line number Diff line
@@ -1588,7 +1588,7 @@ int tc_setup_cb_call(struct tcf_block *block, struct tcf_exts *exts, 
		return ret;

	ok_count = ret;



	if (!exts)

	if (!exts || ok_count)

		return ok_count;

	ret = tc_exts_setup_cb_egdev_call(exts, type, type_data, err_stop);

	if (ret < 0)