Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8e57863 authored by Tvrtko Ursulin's avatar Tvrtko Ursulin
Browse files

drm/i915: Trim partial view sg lists 



Partial views are small but there can be many of them, and since the sg
list space for them is allocated pessimistically, we can save some slab by
trimming the unused tail entries.

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180926080353.20867-1-tvrtko.ursulin@linux.intel.com
parent dee4a0f8

drivers/gpu/drm/i915/i915_drv.h

+2 −0
Original line number Diff line number Diff line
@@ -2325,6 +2325,8 @@ static inline struct scatterlist *__sg_next(struct scatterlist *sg) 
	     (((__iter).curr += PAGE_SIZE) >= (__iter).max) ?		\

	     (__iter) = __sgt_iter(__sg_next((__iter).sgp), false), 0 : 0)



bool i915_sg_trim(struct sg_table *orig_st);



static inline unsigned int i915_sg_page_sizes(struct scatterlist *sg)

{

	unsigned int page_sizes;

drivers/gpu/drm/i915/i915_gem.c

+1 −1
Original line number Diff line number Diff line
@@ -2491,7 +2491,7 @@ void __i915_gem_object_put_pages(struct drm_i915_gem_object *obj, 
	mutex_unlock(&obj->mm.lock);

}



static bool i915_sg_trim(struct sg_table *orig_st)

bool i915_sg_trim(struct sg_table *orig_st)

{

	struct sg_table new_st;

	struct scatterlist *sg, *new_sg;

drivers/gpu/drm/i915/i915_gem_gtt.c

+2 −0
Original line number Diff line number Diff line
@@ -3835,6 +3835,8 @@ intel_partial_pages(const struct i915_ggtt_view *view, 
		count -= len >> PAGE_SHIFT;

		if (count == 0) {

			sg_mark_end(sg);

			i915_sg_trim(st); /* Drop any unused tail entries. */



			return st;

		}